Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Returns the kernel instance in KernelTestCase::bootKernel #7783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Apr 9, 2017 · 1 comment
Closed

[FrameworkBundle] Returns the kernel instance in KernelTestCase::bootKernel #7783

javiereguiluz opened this issue Apr 9, 2017 · 1 comment
Labels
FrameworkBundle hasPR A Pull Request has already been submitted for this issue.
Milestone
3.3

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#22276

This is the new code allowed by this change:

// Before
static::bootKernel($options);
$client = static::$kernel->getContainer()->get('test.client');

// after
$kernel = static::bootKernel($options)
$client = $kernel->getContainer()->get('test.client');

Not sure if we should mention or explain this.
@javiereguiluz javiereguiluz added this to the 3.3 milestone Apr 9, 2017
@xabbuh
Copy link
Member

xabbuh commented Apr 10, 2017

We could update the existing code examples.

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Oct 19, 2017
@javiereguiluz javiereguiluz mentioned this issue Oct 19, 2017
Merged
xabbuh added a commit that referenced this issue Oct 27, 2017
@xabbuh
minor #8530 Updated bootKernel examples to return the $kernel object …
9b08ab8 
…(javiereguiluz)

This PR was merged into the 3.3 branch.

Discussion
----------

Updated bootKernel examples to return the $kernel object

This fixes #7783.

Commits
-------

8c168eb Updated bootKernel examples to return the $kernel object
@xabbuh xabbuh closed this as completed Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@javiereguiluz @xabbuh