Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added support for the "name" attribute in the XLIFF nodes #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Feb 18, 2018 · 0 comments · Fixed by #9302
Closed

Added support for the "name" attribute in the XLIFF nodes #9287

javiereguiluz opened this issue Feb 18, 2018 · 0 comments · Fixed by #9302
Labels
hasPR A Pull Request has already been submitted for this issue.
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#26149. We must check two things:

  1. Add the name attribute to any XLIFF file example we show.
  2. Check if we say somewhere that name is not supported for XLIFF files.
@javiereguiluz javiereguiluz added this to the 4.1 milestone Feb 18, 2018
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Feb 20, 2018
@javiereguiluz javiereguiluz mentioned this issue Feb 20, 2018
Merged
javiereguiluz added a commit that referenced this issue Feb 21, 2018
@javiereguiluz
minor #9302 Added the name attribute to XLIFF 2 documents (javieregui…
8a8b56d 
…luz)

This PR was merged into the master branch.

Discussion
----------

Added the name attribute to XLIFF 2 documents

This fixes #9287. It's a simple fix because we only display one XLIFF 2 document in the docs.

-----

@Nyholm I'm sure you did the right thing ... but just asking: making the `name` value the same as `source` is the best possible solution here? In Symfony's code the `source` attribute is short (https://github.com/symfony/symfony/pull/26149/files) but in real world it can be super long and super ugly (containing `CDATA`, etc.) So, don't you think this will be very verbose? Could we make the `name` value the same as the `id` attribute instead? If the XLIFF standard forces us to do this, then forget my comment and accept my apologies 😄

Commits
-------

30ee49e Added the name attribute to XLIFF 2 documents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Added the name attribute to XLIFF 2 documents javiereguiluz/symfony-docs
1 participant
@javiereguiluz