Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Debug] Support any Throwable object in FlattenException #9636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Apr 20, 2018 · 1 comment · Fixed by #9710
Closed

[Debug] Support any Throwable object in FlattenException #9636

javiereguiluz opened this issue Apr 20, 2018 · 1 comment · Fixed by #9710
Labels
Debug hasPR A Pull Request has already been submitted for this issue.
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#26528

@derrabus you created the original pull request. I'd like to ask you if this change is just internal to Symfony or has impact to end-user apps. If it impacts users, can you please tell us what changes must users make? Thanks a lot!
@javiereguiluz javiereguiluz added this to the 4.1 milestone Apr 20, 2018
@derrabus
Copy link
Member

@javiereguiluz Thanks for reaching out. I will have a look if the documentation has to be adjusted. But since the old methods have not (yet?) been deprecated, there is no action developers have to take now.

The changes that end-users might actually see have been done in symfony/symfony#26028 already.

@derrabus derrabus mentioned this issue Apr 30, 2018
Merged
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Apr 30, 2018
javiereguiluz added a commit that referenced this issue May 2, 2018
@javiereguiluz
minor #9710 FlattenException might also represent an instance of Erro…
953dbd4 
…r (derrabus)

This PR was merged into the master branch.

Discussion
----------

FlattenException might also represent an instance of Error

This PR documents symfony/symfony#26528 and fixes #9636.

Commits
-------

cd309c9 FlattenException might also represent an instance of Error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Debug hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

FlattenException might also represent an instance of Error
2 participants
@javiereguiluz @derrabus