Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation] introduced detailed exceptions to replace the generic FileException #9642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Apr 20, 2018 · 4 comments
Closed

[HttpFoundation] introduced detailed exceptions to replace the generic FileException #9642

javiereguiluz opened this issue Apr 20, 2018 · 4 comments
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. help wanted Issues and PRs which are looking for volunteers to complete them. HttpFoundation
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#26475

added CannotWriteFileException, ExtensionFileException, FormSizeFileException, IniSizeFileException, NoFileException, NoTmpDirFileException, PartialFileException to handle failed UploadedFile.

We may need to update some file upload code sample.
@javiereguiluz javiereguiluz added Missing Documentation good first issue Ideal for your first contribution! (some Symfony experience may be required) HttpFoundation help wanted Issues and PRs which are looking for volunteers to complete them. labels Apr 20, 2018
@javiereguiluz javiereguiluz added this to the 4.1 milestone Apr 20, 2018
@LS05
Copy link
Contributor

LS05 commented Sep 17, 2018

Is it possible for me to work on this? :)

@xabbuh
Copy link
Member

xabbuh commented Sep 19, 2018

@LS05 We would be more than happy to have you working on it. :)

@LS05
Copy link
Contributor

LS05 commented Sep 19, 2018

@xabbuh I'll do it :) I really want to contribute to Symfony!

@xabbuh
Copy link
Member

xabbuh commented Sep 19, 2018

Don't hesitate to ask if you have any questions. You can also join us on the Symfony Slack in in the #documentation channel.

@LS05 LS05 mentioned this issue Sep 23, 2018
Closed
javiereguiluz added a commit that referenced this issue Sep 28, 2018
@javiereguiluz
minor #10382 Update upload_file.rst for handling FileException (LS05)
8baa524 
This PR was submitted for the master branch but it was squashed and merged into the 2.8 branch instead (closes #10382).

Discussion
----------

Update upload_file.rst for handling FileException

#9642
Handled FileException in coding examples. We need to discuss how to handle specific file exceptions ;)

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

0a5e663 Update upload_file.rst for handling FileException
@javiereguiluz javiereguiluz mentioned this issue Oct 18, 2018
Closed
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. help wanted Issues and PRs which are looking for volunteers to complete them. HttpFoundation
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
3 participants
@javiereguiluz @LS05 @xabbuh