[Routing] Add locale fallback to internationalized routes #10108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
32051bd to
c15df9d
Compare
routing.rst
Outdated
| @@ -210,6 +210,17 @@ should be used during the request. Defining routes this way also eliminated the | |||
| need for duplicate registration of routes which minimizes the risk for any bugs | |||
| caused by definition inconsistency. | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| If you use full locales (language + territory) in your application (e.g. `fr_FR`), | |||
There was a problem hiding this comment.
Not sure about this, I took it from Wikipedia and the info seems to come from the ISO standard (https://en.wikipedia.org/wiki/Locale_(computer_software)).
routing.rst
Outdated
| for several full locales that share the same language (e.g. `fr_FR` and `fr_BE`). | ||
|
|
||
| .. versionadded:: 4.2 | ||
| The feature to fall back on the language part only was introduced in Symfony 4.2. |
There was a problem hiding this comment.
I think "fallback" is the noun, and "fall back" the verb (https://english.stackexchange.com/questions/90549/difference-between-fallback-and-fall-back)
|
upstream merged |
1 similar comment
|
upstream merged |
symfony-splitter
pushed a commit
to symfony/routing
that referenced
this pull request
Aug 10, 2018
…nationalized routes (fancyweb) This PR was merged into the 4.2-dev branch. Discussion ---------- [Routing] Add fallback to cultureless locale for internationalized routes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#27938 | License | MIT | Doc PR | symfony/symfony-docs#10108 Please check the related issue for the context. TODO : - [x] Update CHANGELOG - [x] Update documentation Commits ------- fd2e3c36fb [Routing] Add fallback to cultureless locale for internationalized routes
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 10, 2018
…nationalized routes (fancyweb) This PR was merged into the 4.2-dev branch. Discussion ---------- [Routing] Add fallback to cultureless locale for internationalized routes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27938 | License | MIT | Doc PR | symfony/symfony-docs#10108 Please check the related issue for the context. TODO : - [x] Update CHANGELOG - [x] Update documentation Commits ------- fd2e3c3 [Routing] Add fallback to cultureless locale for internationalized routes
|
@fancyweb this is a truly convenient feature! Love it. Thanks for contributing it. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 4, 2018
…s (Thomas Calvet, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Routing] Add locale fallback to internationalized routes Related PR : symfony/symfony#27957 Commits ------- 02cc739 Minor reword c15df9d [Routing] Add locale fallback to internationalized routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR : symfony/symfony#27957