Update upload_file.rst for handling FileException #10382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileException handled in examples. This is for bc with 2.8. We need to discuss how to handle specific file exceptions ;)
javiereguiluz
approved these changes
Sep 26, 2018
Typo fixed :)
|
@javiereguiluz I have fixed a typo in there! :) |
HeahDude
approved these changes
Sep 27, 2018
|
Thank you @HeahDude ! Looking forward to do more :) |
javiereguiluz
added a commit
that referenced
this pull request
Sep 28, 2018
This PR was submitted for the master branch but it was squashed and merged into the 2.8 branch instead (closes #10382). Discussion ---------- Update upload_file.rst for handling FileException #9642 Handled FileException in coding examples. We need to discuss how to handle specific file exceptions ;) <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 0a5e663 Update upload_file.rst for handling FileException
|
@LS05 this is now merged! We merged it in 2.8 branch (and we'll merge in the other branches automatically later). By the way, we slightly modified this when merging to add the missing import of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9642
Handled FileException in coding examples. We need to discuss how to handle specific file exceptions ;)