Improved the article about session flashes #10435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which branch should we merge this in? Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Oct 8, 2018
This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #10435). Discussion ---------- Improved the article about session flashes As discussed here symfony/demo#859 Not sure about the branch though. Commits ------- e6ce2f4 Improved the article about session flashes
xabbuh
reviewed
Oct 10, 2018
| @@ -29,7 +29,7 @@ access the flash messages: | |||
|
|
|||
| .. code-block:: html+twig | |||
|
|
|||
| {% if app.request.hasPreviousSession %} | |||
| {% if app.request.method == 'POST' %} | |||
There was a problem hiding this comment.
I do not understand this change. I mean the flash entries will probably be created when processing a POST request, but the reason we register them is that we redirect at the end and we need to display them in response for the subsequent event which will be a GET request then. So with this change the flash messages are likely to never be shown.
There was a problem hiding this comment.
See symfony/demo#859 for more details. People seem convinced that this is the right fix.
There was a problem hiding this comment.
Let me crosspost my comment there too then. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here symfony/demo#859 Not sure about the branch though.