Added new entry for changing the theme in the HtmlDumper #10745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#SymfonyConHackday2018 |
|
I'm really sorry I missed this contribution. Sadly we had a very long backlog of pull requests pending to be reviewed and merged so we forgot about this. What's even more sad it's that we already merged a similar pull request to fix this (#10746). The other pull request is much more concise, which we always prefer to easy future maintenance. So, that's we are closing this pull request without merging. I'm sorry for how bad we managed this ... and we'll strive to make it better in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#SymfonyConHackday2018
Might be the same than #10746
Added new entry and image for the new light theme