Fix the example about overriding the getProjectDir method #11232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method must return the canonical path for things to work fine everywhere.
|
Note that most places will work fine with a non canonical path. But we have a few places which use the root dir to strip it from paths stored in the cache (to make the cache independent from the location of the project at the time it was generated) and these may not always canonicalize the root dir themselves. |
|
Thanks Christophe. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 27, 2019
…d (stof) This PR was merged into the 3.4 branch. Discussion ---------- Fix the example about overriding the getProjectDir method This method must return the canonical path for things to work fine everywhere. Commits ------- d2e3e6b Fix the example about overriding the getProjectDir method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method must return the canonical path for things to work fine everywhere.