Add a documentation about Messenger's transports #11331
Conversation
|
|
||
| class YourTransport implements TransportInterface | ||
| { | ||
| public function send($message) : void |
There was a problem hiding this comment.
| public function send($message) : void | |
| public function send($message) |
or does it come from the interface?
There was a problem hiding this comment.
The method in the SenderInterface looks like this:
public function send(Envelope $envelope): Envelope;| // ... | ||
| } | ||
|
|
||
| public function stop() : void |
There was a problem hiding this comment.
| public function stop() : void | |
| public function stop() |
or does it come from the interface?
|
Just took a quick look - thanks for starting this :). There’s one if problem immediately - it looks like this is a few weeks out of date, and s lot has happened in the past few weeks. Check out the master branch of the code - it’s quite different. Sorry about that! |
|
Thanks all for the review. |
Could you please help me with that? which major parts are changed? |
|
@weaverryan can you please check if this PR is still relevant, compared against the current state of the messenger docs? Thank you |
|
I think due to the many changes in this component since this PR was opened (sorry!) and the fact that I think this is a more advanced thing where looking at the core classes themselves is probably the best way to navigate it, I think we should close this. The only missing thing would probably be something in the main |
|
We're closing this pull request for the reasons given by Ryan in the previous message. @llaakkkk I'm really sorry about this. I hate it when "external changes" force us to close some pull request because the proposed changes are no longer required or for any other reason. Luckily this doesn't happen often ... but sometimes does happen, like this time 😢 I hope this doesn't discourage you from making future contributions. We'll be happy to merge them! Thanks. |
Closes #9756