Thanks to visit codestin.com
Credit goes to github.com

Skip to content

adding a custom method to define the priority of services #11731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 47 commits into from

Conversation

pcabreus
Copy link

This documents symfony/symfony#31943 about adding a custom method to define the priority of services

Simperfit and others added 30 commits May 29, 2019 07:32
…are (Simperfit)

This PR was merged into the master branch.

Discussion
----------

[Messenger]minor: update remove of loggingmiddleware

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

This follows the update to 5.0 by removing the logging middlewere from the docs

Commits
-------

90ba4de minor: update remove of loggingmiddleware
* 4.4:
  Improve doc for HttpClient
* 4.4:
  Remove short factories/configurators examples
* 4.4:
  fix encore multiple configuration build paths
* 4.4:
  Deprecate the LoggingMiddleware in Symfony 4.3
…ereguiluz)

This PR was merged into the master branch.

Discussion
----------

Removed Symfony 4.* versionadded directives

"Master" branch will become Symfony 5.0, so we can remove all this.

Commits
-------

bcc55c5 Removed Symfony 4.* versionadded directives
* 4.4:
  Updating messenger docs for 4.3
  [HttpClient] Fixed some wrong class FQCN
  [HttpClient] Fixed some missing references
* 4.4:
  fixing syntax
  [HttpClient] add note about getInfo(debug)
* 4.4:
  Fix `validation.not_compromised_password` option default
* 4.4:
  Deprecate the templating.* options of FrameworkBundle
* 4.4:
  [Contributing] Fixed a wrong reference
  Removed the deprecated factory YAML config
This PR was squashed before being merged into the master branch (closes symfony#11621).

Discussion
----------

Removed deprecated contents

This is related to symfony#11620 and removes deprecated things.

The only remaining deprecation is the `transChoice()` method. I'm leaving that for future PRs because @wouterj created a big PR pending to be merged related to that.

Commits
-------

ce64ac2 Removed deprecated contents
* 4.4:
  Document changes in the deprecation error handler
* 4.4:
  Minor reword
  [Validator][Doctrine] Add docs for automatic validation
* 4.4:
  [Security] Expression voter
* 4.4:
  Fix a few minor misprints in Mailer article
  deprecating Swift Mailer and moving all docs into one spot and moving many docs from mime to Mailer and writing it
  Yet another great review!
  Add link to usefull online editor
  Fixes after thorough reviews!
  Removed further usage of transchoice in the docs
  Added documentation on the ICU MessageFormat
  Some general fixes/improvements for translation guide
* 4.4:
  Fix several typos
* 4.4:
  Remove chrome debug since it's no longer present
  Fix several typos
  [symfony#11635] Fixed syntax
  11627 Minor/Patch version fix
  edit normalizer deprecated method on 4.2
* 4.4:
  Removed IBAN docs, not available in version 4.2
* 4.4:
  tweaks to messenger docs based on feedback from @Tobion
* 4.4:
  Update installation.rst
* 4.4:
  fix(DI): service name
* 4.4:
  fix constraint reference YAML config syntax
* 4.4:
  [HttpClient] improve doc again
  [Mailer] Sort providers alphabetically
* 4.4:
  Fixing docs about switch_user and custom voters
* 4.4:
  [HttpClient] Documented the cancel() method
javiereguiluz and others added 17 commits June 5, 2019 08:57
* 4.4:
  Clarifying that you can't override real env vars
* 4.4:
  fixes missing "use" declaration for the ClockMock
* 4.4:
  Update symfony 4 project structure
* 4.4:
  Remvove space before self-closing xml tag
* 4.4:
  Use .yaml instead of .yml
  Update mailer.rst
* 4.4:
  Update mailer.rst
* 4.4:
  auth_basic is a scalar type
* 4.4:
  Show DomCrawler results consistent
* 4.4:
  Fix markup
  Update mailer.rst
  Use .xlf extension
  Removed blank line after filepath
  Ordered use statements
  Blank line after directive and no blank line after filepath
* 4.4:
  Added a section about belittling words to the documentation standars
* 4.4:
  [symfony#11330] Restructured the Migration guide a bit while proof-reading
  Creates a migration guide.
* 4.4:
  [EventDispatcher] Use the classes from Contracts instead of the component
  [DI] Use classes from Contracts instead of the component
* 4.4:
  [Routing] Simplified some doc
* 4.4:
  Update conventions.rst
  Require Dotenv component without --dev
  Fixed a minor RST syntax issue
* 4.4:
  Recommend FOSCKE instead of Ivory WYSIWYG editor
  Use current version for deprecated/versionadded examples
@javiereguiluz
Copy link
Member

@pcabreus there is some problem with your pull request ... it contains more commits than it should.

Don't worry, this has happened to all of us before because Git is sometimes tricky. If you don't want to waste time fixing this, it's OK to close this and open a new pull request. If you need help, you can ask for help about contributing in the #contribs channel of Symfony Slack (https://symfony.com/slack). Thanks.

@pcabreus
Copy link
Author

@javiereguiluz thanks for the awnser but I can't access to the Symfony Slack because I created it been in Cuba, Now Im living in Barcelona but I'm still deactivated by admins, sorry for it I might contribute more...

@pcabreus pcabreus closed this Jun 20, 2019
@pcabreus pcabreus deleted the patch-1 branch June 20, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants