feature: add docs for extra fields #11814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jun 23, 2019
73e4f2f to
879e1fe
Compare
weaverryan
requested changes
Jun 28, 2019
|
|
||
| **type**: ``array`` **default**: ``null`` | ||
|
|
||
| This is the custom fields to pull from the LDAP server. If the fields does not |
There was a problem hiding this comment.
Defines the custom fields...
... If any field does not exist, an Invalid... will be thrown.
879e1fe to
76dadf8
Compare
javiereguiluz
added a commit
that referenced
this pull request
Jul 2, 2019
This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes #11814). Discussion ---------- feature: add docs for extra fields <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Fix #11810 Commits ------- 76dadf8 feature: add docs for extra fields
|
Thanks Hamza for this contribution! I made Ryan's suggested changes while merging and I also added the missing "versionadded:: 4.4" directive. |
|
Thanks Javier, I forgot about Ryan's suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11810