Documented the ErrorRenderer component #11864
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Jul 2, 2019
yceruto
reviewed
Jul 2, 2019
ihmels
reviewed
Jul 9, 2019
|
This document needs to be divided, now the ErrorRenderer component contains only the renderer layer and the new ErrorHandler component (symfony/symfony#32471) contains the handlers. |
|
@yceruto is this still necessary or can we close this PR? |
|
I think the ErrorRenderer part is still good. I will try to update it according to the latest changes. |
|
See #12187, Javier, feel free to continue your work there. |
|
Let's close this in favor of #12187. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 19, 2019
…aviereguiluz, yceruto) This PR was merged into the 4.4 branch. Discussion ---------- Documenting ErrorRenderer and ErrorHandler components Replace #11864 Closes #12193 #12009 #11980 #12015 #12019 #12029 Should we remove the whole Debug component documentation? or remove only the details and say it's deprecated? Commits ------- 8cc084f documenting the ErrorHandler::call method 3ea9817 fix service definition 5a025c9 fix example 5136a17 Update with latest changes: ErrorRenderer and ErrorHandler components b0723ef Fixed a method name b600b3c Renamed ErrorCatcher as ErrorRenderer 4e333c1 Fixes b2a1a9b Documented the ErrorCatcher component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11837.
I'll need help for some things:
Thanks.