-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[PropertyInfo] Mentioned the phpDoc collection type #11866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@popy-dev I know that you implemented this feature a long ago (thanks for that!) but, could you please review if this proposed change is correct? Thanks. |
|
||
.. versionadded:: 4.2 | ||
|
||
The support of phpDocumentor collection types was introduced in Symfony 4.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a link to the phpDocumentor library?
It seems fine to me. Maybe you could give more "open" example (the Iterator class can, in fact, be any class, and collection values also), but I guess that's nitpicking :) |
@popy-dev thanks for reviewing! I have some problems trying to fully understand this feature so ... could you please show me some valid examples that don't use the |
The idea is to be able to give more details about a property type. If you have an array of Items, you can use the As an actual example, if you're familiar with doctrine collection, you could annotate a OneToMany collection with :
|
@popy-dev thanks a lot for your great and detailed explanation. I can fully understand this now and I've updated the explanation to show better examples. Thanks! |
This fixes #10338.