Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use new Event names #12007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

Use new Event names #12007

merged 1 commit into from
Jul 30, 2019

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Jul 22, 2019 •
edited
Loading

Based on symfony/symfony#28920

@symfony/team-symfony-docs shall we add versionadded directives?

@OskarStark OskarStark added this to the 4.3 milestone Jul 22, 2019
@OskarStark OskarStark changed the title Use ExceptionEvent instead of deprecated GetReponseForExceptionEvent Use new Event names Jul 22, 2019
@OskarStark
Copy link
Contributor Author

Friendly ping @nicolas-grekas for a review 😄

@OskarStark OskarStark requested a review from javiereguiluz July 22, 2019 11:44
@javiereguiluz
Copy link
Member

I remember merging a few PRs updating this ... and closing other ones for already having done the proposed changes. Please, double check that what you are changing isn't already changed in the latest version of 4.3 branch. Thanks!

@OskarStark
Copy link
Contributor Author

OskarStark commented Jul 23, 2019 •
edited
Loading

Thanks for you approval Nicolas 👍

I remember merging a few PRs updating this ... and closing other ones for already having done the proposed changes. Please, double check that what you are changing isn't already changed in the latest version of 4.3 branch. Thanks!

I remembered the same, but didn't found the PR's. Anyway I updated the 4.3 branch to the latest remote version before creating this PR 👍

What is still open: versionadded directives? If yes, where

@OskarStark OskarStark requested review from javiereguiluz and removed request for javiereguiluz July 27, 2019 07:03
@OskarStark
Copy link
Contributor Author

I added the deprecation here: d20e0df

Ready to merge from my side!

@OskarStark OskarStark requested a review from xabbuh July 29, 2019 06:44
@OskarStark OskarStark merged commit 00f3807 into symfony:4.3 Jul 30, 2019
OskarStark added a commit that referenced this pull request Jul 30, 2019
@OskarStark
minor #12007 Use new Event names (OskarStark)
8e80991 
This PR was squashed before being merged into the 4.3 branch (closes #12007).

Discussion
----------

Use new Event names

Based on symfony/symfony#28920

@symfony/team-symfony-docs shall we add `versionadded` directives?

Commits
-------

00f3807 Use new Event names
@OskarStark OskarStark deleted the event-names branch December 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @javiereguiluz @nicolas-grekas @xabbuh @carsonbot