Update expressions.rst #12132
Merged
Update expressions.rst #12132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 10, 2019
| @@ -56,7 +56,9 @@ Additionally, you have access to a number of functions inside the expression: | |||
| Returns ``true`` if the user is authenticated via "remember-me" or authenticated | |||
| "fully" - i.e. returns true if the user is "logged in". | |||
| ``is_anonymous`` | |||
| Equal to using ``IS_AUTHENTICATED_ANONYMOUSLY`` with the ``isGranted()`` function. | |||
| Returns ``true`` if the user is anonymous. That is, the firewall confirms that it | |||
| does not know this user's identity. This is different from ``IS_AUTHENTICATED_ANONYMOUSLY``, | |||
There was a problem hiding this comment.
What about renaming it to „IS_AUTHENTICATED_OR_ANONYMOUSLY“ to make it more clear and understandable?
cc @chalasr
There was a problem hiding this comment.
Sure, but that seems like a topic for its own PR?
There was a problem hiding this comment.
Absolutely this must be implemented int the code base first 👌🏻
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you @chalasr 👍
Could you approve this PR?
There was a problem hiding this comment.
It's not ready yet! This PR is correct for lower versions anyways
chalasr
approved these changes
Aug 14, 2019
Clarify the difference between the `is_anonymous` function and `IS_AUTHENTICATED_ANONYMOUSLY`.
|
Thank you Kevin. |
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #12132). Discussion ---------- Update expressions.rst Clarify the difference between the `is_anonymous` function and `IS_AUTHENTICATED_ANONYMOUSLY`. This fixes #11950. Commits ------- 6df9898 Update expressions.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the difference between the
is_anonymousfunction andIS_AUTHENTICATED_ANONYMOUSLY.This fixes #11950.