Mention ISO 639 for languages #12173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
Looks good to me shall I merge everything in 4.4 and master afterwards and you will send a PR against 4.4 @ro0NL ?
|
@OskarStark yes 👍 |
|
Thank you Roland. |
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was squashed before being merged into the 4.3 branch (closes #12173). Discussion ---------- Mention ISO 639 for languages we've added this in 4.4 (#12105), but languages in 4.3 already had (partial) alpha3 support. let me know if this is merged in 4.4 :) it needs some cleanup after. cc @OskarStark Commits ------- 8ee8df7 Mention ISO 639 for languages
|
Done and upmerged to |
Merged
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Update intl.rst follow up of #12173 (cc @OskarStark) Commits ------- b9ac17b Update intl.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've added this in 4.4 (#12105), but languages in 4.3 already had (partial) alpha3 support.
let me know if this is merged in 4.4 :) it needs some cleanup after.
cc @OskarStark