Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update typehints #12867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

Update typehints #12867

merged 1 commit into from
Oct 21, 2020

Conversation

atailouloute
Copy link
Contributor

No description provided.

@atailouloute atailouloute requested a review from xabbuh as a code owner December 30, 2019 07:46
@atailouloute atailouloute mentioned this pull request Dec 30, 2019
Closed
@wouterj wouterj changed the base branch from 5.0 to 5.1 October 21, 2020 11:43
@wouterj wouterj requested a review from HeahDude as a code owner October 21, 2020 11:43
@wouterj wouterj merged commit 77a53e4 into symfony:5.1 Oct 21, 2020
@wouterj
Copy link
Member

wouterj commented Oct 21, 2020

Thanks a lot @atailouloute! This is a very complete and correct PR adding typehints.

I'm sorry for the long wait. PRs like this take some time to review (we have to check each change), so we all seemed to have postponed reviewing it way to long.

Meanwhile, the 5.0 branch is unmaintained, so I've rebased it on 5.1 and merged the PR. Thanks again, this is great!

@wouterj wouterj mentioned this pull request Oct 21, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atailouloute @wouterj @carsonbot