Adding details about recipe upgrade system and upgrade improvements #12959
Conversation
setup/upgrade_major.rst
Outdated
| - "symfony/config": "4.4.*", | ||
| + "symfony/config": "5.0.*", | ||
| - "symfony/console": "4.4.*", | ||
| + "symfony/console": "5.0.*", |
There was a problem hiding this comment.
I thought the diff rormat would be more useful here.
Also, in practical terms, ever since the extra.symfony.require key was added, when you intall a Symfony package, it uses the version constraint format 4.4.* not ^4.4. And so, for consistency, I'm showing that format and telling people to continue using it.
076636c to
036532c
Compare
| @@ -1,7 +1,7 @@ | |||
| .. index:: | |||
| single: Upgrading; Major Version | |||
|
|
|||
| Upgrading a Major Version (e.g. 3.4.0 to 4.1.0) | |||
| Upgrading a Major Version (e.g. 4.4.0 to 5.0.0) | |||
| - "symfony/config": "4.3.*", | ||
| + "symfony/config": "4.4.*", | ||
| - "symfony/console": "4.3.*", | ||
| + "symfony/console": "4.4.*", |
There was a problem hiding this comment.
Are we sure this is the case? (I'm on Windows atm, so I cannot test it)
If I'm reading https://github.com/symfony/skeleton/blob/master/composer.json correctly, the dependencies are actually marked as * and the extra.symfony.require is used to limit the scope to a specific minor version. That would mean you only need to update that value?
There was a problem hiding this comment.
Yes ... that's how I've seen it in modern Symfony apps ... but the reader of this document can use any method actually, especially if they are upgrading from very old Symfony versions.
There was a problem hiding this comment.
In practice, when you compose require symfony/something, it will put the X.X.* version constraint in your composer.json file. So... I'm trying to show an example that will look "like" the user's composer.json file. But technically speaking, you're totally right: if they had ^4.0 everywhere, they could upgrade/control the Symfony versions simply by changing extra.symfony.require. But that's not how things currently will look in real apps.
I talked with Nicolas about this, and I think it (the usage the X.X.* format by composer require) was more-or-less an "accidental" by-product of the extra.symfony.require feature
|
Thanks everyone for the review - this should be ready now :) |
d423e58 to
6305e83
Compare
|
Thank you Ryan. |
…mprovements (weaverryan) This PR was squashed before being merged into the 4.3 branch (closes #12959). Discussion ---------- Adding details about recipe upgrade system and upgrade improvements Hi! The big thing here is to mention the new Flex commands related to upgrading secrets. Also, the major upgrade version doc was out-of-date. Apologies if there is already a PR open to fix this (if there is, I missed it). Cheers! Commits ------- 6305e83 Adding details about recipe upgrade system and upgrade improvements
* 4.3: Fix build. Refs #12959
* 4.4: Fix build. Refs #12959
* 5.0: Fix build. Refs #12959
Hi!
The big thing here is to mention the new Flex commands related to upgrading secrets. Also, the major upgrade version doc was out-of-date. Apologies if there is already a PR open to fix this (if there is, I missed it).
Cheers!