[Messenger] Note about serializer #12989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27e3a0f to
09d4c7a
Compare
javiereguiluz
added a commit
that referenced
this pull request
Feb 17, 2020
This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes #12989). Discussion ---------- [Messenger] Note about serializer The issue is that I've multiple times heard people saying: > I like Messenger component, but it does not work if you send messages from one app to another. First I wanted to solve this issue by adding a new page just saying "YES YOU CAN". But for now, I settle with a small note and a link to Symfony Cast explaining this. There is also a great over engineered package that I believe everybody should use... but I dont feel link symfony docs is a place to promote a package like this, or is it? https://github.com/Happyr/message-serializer I think this will fix symfony/symfony#35439 Commits ------- 09d4c7a [Messenger] Note about serializer
|
This was finally merged. Thanks Tobias! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that I've multiple times heard people saying:
First I wanted to solve this issue by adding a new page just saying "YES YOU CAN".
But for now, I settle with a small note and a link to Symfony Cast explaining this.
There is also a great over engineered package that I believe everybody should use... but I dont feel link symfony docs is a place to promote a package like this, or is it? https://github.com/Happyr/message-serializer
I think this will fix symfony/symfony#35439