Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Routing] add priority option to annotated routes #13113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2020
Merged

[Routing] add priority option to annotated routes #13113

merged 1 commit into from
Feb 23, 2020

Conversation

MrYamous
Copy link
Contributor

PR for issue #13059

@HeahDude HeahDude linked an issue Feb 19, 2020 that may be closed by this pull request
[Routing] add priority option to annotated routes #13059
Closed
@HeahDude HeahDude added this to the 5.1 milestone Feb 19, 2020
HeahDude
HeahDude reviewed Feb 19, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR

@MrYamous
Copy link
Contributor Author

Thanks @HeahDude for your review

@OskarStark OskarStark requested a review from HeahDude February 19, 2020 10:05
HeahDude
HeahDude reviewed Feb 19, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, thanks

HeahDude
HeahDude reviewed Feb 19, 2020
View reviewed changes
HeahDude
HeahDude reviewed Feb 19, 2020
View reviewed changes
HeahDude
HeahDude approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good now. Last comments about the code style, but they can be fixed on merge. Thanks!

@HeahDude
Copy link
Contributor

I've handled the last changes, thank you for this contribution.

@HeahDude HeahDude merged commit e0b177e into symfony:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude HeahDude approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Routing] add priority option to annotated routes
4 participants
@MrYamous @HeahDude @OskarStark @carsonbot