Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Updated unit testing article #13552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

[Form] Updated unit testing article #13552

merged 1 commit into from
May 18, 2020

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude added the Form label Apr 16, 2020
@HeahDude HeahDude added this to the 3.4 milestone Apr 16, 2020
@HeahDude HeahDude changed the base branch from master to 3.4 April 16, 2020 11:57
@HeahDude HeahDude mentioned this pull request Apr 16, 2020
Closed
wouterj
wouterj reviewed Apr 16, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jules! Great to have you working on both repositories, so code issues can be solved with doc changes :)

xabbuh
xabbuh approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the minor changes suggested by Wouter

@javiereguiluz javiereguiluz merged commit de83642 into symfony:3.4 May 18, 2020
@javiereguiluz
Copy link
Member

Thanks Jules for these improvements! Wouter, I did your suggested changes while merging.

@GPHemsley-RELX
Copy link

IMO, these changes aren't enough to cover the material laid out in symfony/symfony#36462 (comment).

In particular, these questions are not answered by these changes:

  • How does one register an extension?
  • What does DoctrineOrmExtension do, why is it needed, and how does one use it?
  • How does mocking ManagerRegistry help? How does it interact with DoctrineOrmExtension?
  • Why would one not be able to use a mock to write their test?
  • How would one use the form.factory service?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@HeahDude @javiereguiluz @GPHemsley-RELX @wouterj @xabbuh @carsonbot