Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] Replace has_role by is_granted #13566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

[Workflow] Replace has_role by is_granted #13566

merged 1 commit into from
Apr 20, 2020

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Apr 19, 2020

As in changelog of security component version 5.0:

Removed the `has_role()` function from security expressions, use `is_granted()` instead.

@wouterj wouterj added this to the 4.4 milestone Apr 19, 2020
wouterj
wouterj approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

For the merger: this function already exists in 4.4, so let's merge it in 4.4. We can manage that during the merge, so you don't have to change anything :)

@javiereguiluz javiereguiluz changed the base branch from 5.0 to 4.4 April 20, 2020 07:36
@javiereguiluz
Copy link
Member

Thank you @tienvx.

@javiereguiluz javiereguiluz merged commit 006ea45 into symfony:4.4 Apr 20, 2020
@tienvx tienvx deleted the replace-has_role-by-is_granted branch April 20, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@tienvx @javiereguiluz @wouterj @maxhelias @carsonbot