Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update framework.rst #13772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update framework.rst #13772

wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor

@ThomasLandauer ThomasLandauer mentioned this pull request Jun 7, 2020
Closed
@xabbuh xabbuh added this to the 4.4 milestone Jun 7, 2020
@ro0NL
Copy link
Contributor

ro0NL commented Jun 7, 2020

you do realize this is the annotations.debug setting right 😬

The guard clause in question is directly set by kernel.debug - https://github.com/symfony/symfony/blob/e9be7418a3da925a5b5db51728c5c421ac899ead/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml#L115

perhaps it's better to clarify in practice

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Resources/welcome.html.php#L68
[...] and debug mode is enabled.

@ThomasLandauer
Copy link
Contributor Author

Oops, sorry! I'm closing this here quickly, to avoid more confusion ;-)

You mean adding the info about kernel.debug in the very message on the welcome page itself? Well, yeah, since the welcome page isn't documented anywhere in the docs (or is it?), this is probably the best (in fact: only) place to explain it :-)

@ThomasLandauer ThomasLandauer mentioned this pull request Jun 7, 2020
Merged
@ThomasLandauer
Copy link
Contributor Author

There you go symfony/symfony#37131 - I hope I got it right this time ;-)

@ThomasLandauer ThomasLandauer deleted the patch-13 branch June 7, 2020 19:35
fabpot added a commit to symfony/symfony that referenced this pull request Jun 8, 2020
@fabpot
minor #37131 Update welcome.html.php (ThomasLandauer)
4d6a02a 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Update welcome.html.php

Added info about `kernel.debug` - see symfony/symfony-docs#13772 (comment) which is a follow-up of #37129

| Q             | A
| ------------- | ---
| Branch?       | 4.4. No need to change 3.4, since it's already present: https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/HttpKernel/Resources/welcome.html.php#L65
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37129
| License       | MIT
| Doc PR        | not necessary

Commits
-------

53491b9 Update welcome.html.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasLandauer @ro0NL @xabbuh @carsonbot