Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added a caution about encoding DSN credentials #13838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

Added a caution about encoding DSN credentials #13838

merged 1 commit into from
Jun 19, 2020

Conversation

nspyke
Copy link
Contributor

@nspyke nspyke commented Jun 14, 2020

Refer to issue symfony/symfony#36669

@nspyke nspyke mentioned this pull request Jun 14, 2020
Closed
Nyholm
Nyholm approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is only 3 or 4 characters you need to encode. We could mention them. But it never hurts to always encode.

I’m happy with this.

@xabbuh xabbuh added this to the 4.4 milestone Jun 16, 2020
@javiereguiluz
Copy link
Member

Nik, thank you and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit e2406fd into symfony:4.4 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nspyke @javiereguiluz @Nyholm @xabbuh @carsonbot