Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Added SQS Messenger docs #14391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 13, 2020
Merged

[Messenger] Added SQS Messenger docs #14391

merged 14 commits into from
Oct 13, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 11, 2020

This will close #13328 and fix #13093

abdel-ben and others added 2 commits October 11, 2020 22:32
Fix provider name `backend_users` instead of `backend`
This PR was submitted for the 5.1 branch but it was merged into the 4.4 branch instead.

Discussion
----------

Update user_provider.rst

Fix provider name `backend_users` instead of `backend`

Commits
-------

34bacb5 Update user_provider.rst
@Nyholm
Copy link
Member Author

Nyholm commented Oct 11, 2020

This PR should target 5.1

@Nyholm
Copy link
Member Author

Nyholm commented Oct 11, 2020

There you go @OskarStark. Im done with this PR now

Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this PR @Nyholm

@jderusse
Copy link
Member

should we talk about async-aws, and authentication mechanism that fallback to .ini files, EC2/Lambda roles, Eks webidentity... and key/secret are not required

@Nyholm
Copy link
Member Author

Nyholm commented Oct 12, 2020

Hm.. Im not sure we should. Access key/secret is a really good way for new users. Advanced users will look at the code and find AsyncAws and find their way...
We dont want to duplicate the docs from AsyncAws

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing these docs!


.. versionadded:: 5.1

The Amazon SQS transport has been added in Symfony 5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll make this change while merging, but for your information, the versionadded messages are standardized as: XXX was introduced in Symfony N.N.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I leave this unchanged then.

@OskarStark
Copy link
Contributor

Note for the mergers, this must target 5.1 branch

@javiereguiluz javiereguiluz added this to the 5.1 milestone Oct 12, 2020
@Nyholm
Copy link
Member Author

Nyholm commented Oct 12, 2020

I've updated the PR

Nyholm and others added 11 commits October 13, 2020 18:22
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.

Discussion
----------

Remove Michelle from the CARE team

She has resigned.

Commits
-------

cb0c526 Remove Michelle from the CARE team
* 4.4:
  Remove Michelle from the CARE team
  Update user_provider.rst
@wouterj wouterj changed the base branch from 5.x to 5.1 October 13, 2020 16:32
@wouterj wouterj merged commit f7b8aca into symfony:5.1 Oct 13, 2020
wouterj added a commit that referenced this pull request Oct 13, 2020
@wouterj
Copy link
Member

wouterj commented Oct 13, 2020

Thanks @Nyholm and @Simperfit!

During the merge, I mistakingly added some commits that should also have made it in 5.1 (from 4.4). So the diff of this PR is a bit weird, but the result is correct.

Afterwards, I've fixed the comment of @javiereguiluz along with some minor formatting changes in 23fd9b4

@Nyholm
Copy link
Member Author

Nyholm commented Oct 13, 2020

Thank you

wouterj added a commit that referenced this pull request Oct 13, 2020
* 5.1:
  [#14391] Minor (mostly formatting) improvements
  Sort alphabetically
  Typos
  minor
  Typo
  Syntax fix
  syntax
  cs
  Added SQS Messenger docs
  feat: add amazon sqs to docs
  Remove Michelle from the CARE team
  Update user_provider.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger] Add SQS transport
8 participants