Use integer type instead of int & boolean instead of bool #14529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ybenhssaien thanks for this contribution! However, the fix should be the opposite. We use |
|
@javiereguiluz I created a new rule for this case |
|
@ybenhssaien would you like to fix You can see what needs to be fixed for |
|
Done for |
|
@OskarStark done |
OskarStark
approved these changes
Nov 12, 2020
|
Thank you Youssef. |
OskarStark
added a commit
that referenced
this pull request
Nov 12, 2020
…l (ybenhssaien) This PR was squashed before being merged into the 5.1 branch. Discussion ---------- Use integer type instead of int & boolean instead of bool Uses the same type hint `int` already used in the `optimizations` config # Update - [x] Replace `int` by `integer` - [x] Replace `bool` by `boolean` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `5.x` for features of unreleased versions). --> Commits ------- 120290d Replace bool by boolean fc22075 Use integer typehint instead int 2c0cad0 Use int type instead integer
OskarStark
added a commit
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the same type hint
intalready used in theoptimizationsconfigUpdate
intbyintegerboolbyboolean