Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RateLimiter] Fix config keys for rate limiter #14692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

[RateLimiter] Fix config keys for rate limiter #14692

merged 1 commit into from
Dec 11, 2020

Conversation

pierredup
Copy link
Contributor

The lock and storage keys have been updated to lock_factory and storage_service respectively.

@pierredup
Fix config keys for rate limiter
f7ae0fa 
The `lock` and `storage` keys have been updated to `lock_factory` and `storage_service` respectively.
@carsonbot carsonbot changed the title Fix config keys for rate limiter [RateLimiter] Fix config keys for rate limiter Dec 11, 2020
@javiereguiluz javiereguiluz added this to the 5.2 milestone Dec 11, 2020
@javiereguiluz
Copy link
Member

The proposed changes are correct according to https://github.com/symfony/symfony/blob/26e1e6b18efb57ac4d006fa756bdf8681f1d151a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L1833 and https://github.com/symfony/symfony/blob/26e1e6b18efb57ac4d006fa756bdf8681f1d151a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L1841

Thanks Pierre!

@javiereguiluz javiereguiluz merged commit fc17ad3 into symfony:5.2 Dec 11, 2020
@pierredup pierredup deleted the patch-5 branch December 11, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RateLimiter Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pierredup @javiereguiluz @carsonbot