Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Configuration of the message_bus to use #15045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2021
Merged

[Mailer] Configuration of the message_bus to use #15045

merged 1 commit into from
Mar 11, 2021

Conversation

t-richard
Copy link
Contributor

Documents symfony/symfony#34648

Closes #12736

@carsonbot
Copy link
Collaborator

Hey!

Haha, I was thinking of doing this exact same thing. =)

But you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.2.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 5.1 milestone Feb 28, 2021
@t-richard t-richard changed the base branch from 5.1 to 5.2 February 28, 2021 22:29
@javiereguiluz javiereguiluz modified the milestones: 5.1, 5.2 Mar 1, 2021
Nyholm
Nyholm approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though this was document already.

Well done!

@t-richard
Copy link
Contributor Author

I'm currently going through the 5.1 milestone in the issues and trying to document missing features listed there, that's how I caught it 🙂

@Nyholm
Copy link
Member

Nyholm commented Mar 2, 2021

Nice. You are the best!

That is very appreciated and a great way learn about (new) features.

@t-richard
Copy link
Contributor Author

Actually got the idea from you some months ago 😉

And had some time lately to contribute !

OskarStark
OskarStark reviewed Mar 11, 2021
View reviewed changes
OskarStark
OskarStark requested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing version added directive, thanks

@OskarStark
Copy link
Contributor

Thank you Thibault.

@OskarStark OskarStark merged commit bbadeae into symfony:5.2 Mar 11, 2021
@t-richard t-richard deleted the mailer-message-bus branch March 11, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Nyholm approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Mailer Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@t-richard @carsonbot @Nyholm @OskarStark @maxhelias @javiereguiluz