Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PropertyAccess]  do not pass boolean constructor flags #15080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2021
Merged

[PropertyAccess]  do not pass boolean constructor flags #15080

merged 4 commits into from
Mar 9, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 9, 2021

@xabbuh xabbuh added this to the 5.3 milestone Mar 9, 2021
@carsonbot carsonbot changed the title [PropertyAccess] do not pass boolean constructor flags [PropertyAccess]  do not pass boolean constructor flags Mar 9, 2021
@OskarStark
Copy link
Contributor

The referenced ticket looks wrong 🤔

@xabbuh xabbuh mentioned this pull request Mar 9, 2021
Merged
@xabbuh
Copy link
Member Author

xabbuh commented Mar 9, 2021

see #15079 (comment)

Does it clarify things?

javiereguiluz and others added 3 commits March 9, 2021 19:44
@javiereguiluz
minor symfony#15079 [PropertyAccess] use bitwise instead of boolean f…
c26e7a8 
…lags (xabbuh)

This PR was merged into the 5.2 branch.

Discussion
----------

[PropertyAccess] use bitwise instead of boolean flags

see symfony/symfony#32133

Commits
-------

c5101c7 [PropertyAccess] use bitwise instead of boolean flags
@javiereguiluz
Merge branch '5.2' into 5.x
567ccbc 
* 5.2:
  [PropertyAccess] use bitwise instead of boolean flags
@xabbuh @javiereguiluz
[PropertyAccess] do not pass boolean constructor flags
a9cb63d
@javiereguiluz
Copy link
Member

Thanks Christian.

@javiereguiluz javiereguiluz merged commit 081b6ae into symfony:5.x Mar 9, 2021
@xabbuh xabbuh deleted the symfony-39693 branch March 10, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

+1 more reviewer

@maxhelias maxhelias maxhelias approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PropertyAccess Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @OskarStark @javiereguiluz @maxhelias @carsonbot