[Validator] Add normalizer option to Unique constraint #15124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Mar 21, 2021
OskarStark
reviewed
Mar 21, 2021
reference/constraints/Unique.rst
Outdated
| :phpfunction:`trim` PHP function to each element of the collection in order to ignore leading and trailing | ||
| whitespace during validation. | ||
|
|
||
| .. _`PHP callable`: https://www.php.net/callable |
There was a problem hiding this comment.
Please move this to the bottom of the file
| For example, you may want to pass the ``'trim'`` string to apply the | ||
| :phpfunction:`trim` PHP function to each element of the collection in order to ignore leading and trailing | ||
| whitespace during validation. | ||
|
|
There was a problem hiding this comment.
Please add a versionadded directive
The ''normalizer'' option was introduced in Symfony 5.3.
' is a backtick, I am currently on a phone 📱😄
reference/constraints/Unique.rst
Outdated
| @@ -107,8 +109,8 @@ Options | |||
|
|
|||
| .. include:: /reference/constraints/_groups-option.rst.inc | |||
|
|
|||
| message | |||
| ~~~~~~~ | |||
| ``message`` | |||
There was a problem hiding this comment.
Is this the case for all constraints? If yes this should be fixed in the lowest maintained branch (4.4) for the constraints.
We would be glad to receive such a PR from your side, but if you don't have time, no worries.
This should not be fixed in this PR, so please revert this line, thanks
|
@OskarStark thanks. fixed |
xabbuh
approved these changes
Mar 26, 2021
227c9a1 to
92072d9
Compare
|
Andrii, thanks for this nice contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Documenting the feature symfony/symfony#38488 about
normalizeroption for Unique constraint.Thanks!