Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mercure] update mercure documentation #15149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

azjezz
Copy link
Contributor

@azjezz azjezz commented Mar 24, 2021

No description provided.

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tagged the new releases, we can merge this one now! I made some minor change requests.

@javiereguiluz
Copy link
Member

In which version should we merge this? This article is available in 4.4, 5.2 and 5.x branches. Thanks!

@azjezz
Copy link
Contributor Author

azjezz commented Apr 6, 2021

In which version should we merge this? This article is available in 4.4, 5.2 and 5.x branches. Thanks!

mercure and mercure-bundle don't follow symfony versioning, these changes apply to mercure 0.5 and mercure-bundle 0.3, so i'm not really sure.

@azjezz azjezz marked this pull request as ready for review April 6, 2021 10:33
@azjezz azjezz force-pushed the mercure branch 2 times, most recently from 2ccaec5 to 271fc58 Compare April 6, 2021 10:41
@chalasr
Copy link
Member

chalasr commented Apr 6, 2021

As symfony/mercure and mercure-bundle are still in 0.x versions, and because the latest versions support all maintained Symfony versions, I suggest to merge this in the 4.4 branch.

@carsonbot carsonbot changed the title update mercure documentation [Mercure] update mercure documentation Apr 6, 2021
@javiereguiluz javiereguiluz added this to the 4.4 milestone Apr 6, 2021
@javiereguiluz javiereguiluz changed the base branch from 5.x to 4.4 April 6, 2021 15:39
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner April 6, 2021 15:39
@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 6, 2021

@azjezz thanks for this contribution! And thanks to reviewers too!

This is now merged in 4.4 branch and up.

@javiereguiluz javiereguiluz merged commit 8081837 into symfony:4.4 Apr 6, 2021
@azjezz azjezz deleted the mercure branch April 6, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants