[Uid] Document the methods to generate and inspect UIDs #15209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Apr 9, 2021
Comment on lines
+385
to
+393
| services: | ||
| Symfony\Component\Uid\Command\GenerateUlidCommand: ~ | ||
| Symfony\Component\Uid\Command\GenerateUuidCommand: ~ | ||
| Symfony\Component\Uid\Command\InspectUlidCommand: ~ | ||
| Symfony\Component\Uid\Command\InspectUuidCommand: ~ |
There was a problem hiding this comment.
I understand why they are optional, but this seems like a really non-DX friendly feature this way. @fancyweb @nicolas-grekas is there a particular reason not to add a config option for this?
There was a problem hiding this comment.
can those commands be enabled by default but configured as https://symfony.com/doc/current/console/hide_commands.html instead?
OskarStark
reviewed
Apr 9, 2021
OskarStark
approved these changes
Apr 9, 2021
859d981 to
2b0c05c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15032.