[Mailer] Ignore X-Transport while signing #15603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure, this does not need to be applied against |
It does. |
|
When I realized that the PR was not on 5.3, I cherry-picked the commit. |
|
This is a bit confusing to me. We're adding this header to the list of ignored ones ... but we don't explain why. Also ... in the related code comment we say: "if you don't ignore this header when using multiple transports, signature will fail" If that's true, shouldn't Symfony itself remove that header when signing the message? |
|
Sorry, my comment does not make sense, I confuse 2 different PRs. Anyway, this should be fixed in the code, not in the docs. |
This was referenced Aug 20, 2021
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 20, 2021
…(metaer) This PR was merged into the 5.3 branch. Discussion ---------- Ignoring X-Transport header while signing email with DKIM | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Related PR | symfony/symfony-docs#15603 | License | MIT Earlier `@fabpot` wrote in symfony/symfony-docs#15603 (comment): > Anyway, this should be fixed in the code, not in the docs. **Original problem** If we have multiple transports and use one of them, signature will contain X-Transport header by default. But email will not: https://github.com/symfony/symfony/blob/810599d2f0fd19558d140c19bc50eb4dc0021a2e/src/Symfony/Component/Mailer/Transport/Transports.php#L56 And signature will be invalid. Commits ------- b684d40 Ignoring X-Transport header while signing email with DKIM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear that X-Transport must be ignored when signing email with using multiple transports in application:
symfony/symfony#39354 (comment)