Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] document cache:pool:invalidate-tags command #16328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kbond
Copy link
Member

@kbond kbond commented Dec 27, 2021

Waiting on symfony/symfony#44692.

@carsonbot carsonbot added this to the 6.1 milestone Dec 27, 2021
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Dec 27, 2021
@carsonbot carsonbot modified the milestones: 6.1, next Dec 27, 2021
chalasr added a commit to symfony/symfony that referenced this pull request Feb 9, 2022
…gs` command (kbond)

This PR was squashed before being merged into the 6.1 branch.

Discussion
----------

[Cache][FrameworkBundle] add `cache:pool:invalidate-tags` command

| Q             | A
| ------------- | ---
| Branch?       | 6.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #40218
| License       | MIT
| Doc PR        | symfony/symfony-docs#16328

Adds a `cache:pool:invalidate-tags` command.

## Usage

```bash
bin/console cache:pool:invalidate-tags tag1 # invalidates tag1 from all taggable pools
bin/console cache:pool:invalidate-tags tag1 tag2 # invalidates tag1 & tag2 from all taggable pools
bin/console cache:pool:invalidate-tags tag1 tag2 --pool=cache.app # invalidates tag1 & tag2 from cache.app pool
bin/console cache:pool:invalidate-tags tag1 tag2 -p cache1 -p cache2 # invalidates tag1 & tag2 from cache1 & cache2 pools
```

## TODO

- [x] tests
- [x] account for #44682 (once merged up to 6.1)

Commits
-------

0657f14 [Cache][FrameworkBundle] add `cache:pool:invalidate-tags` command
@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code Merge Docs for features pending to be merged labels Mar 11, 2022
@javiereguiluz
Copy link
Member

Before merging this, I'd like to wait for opinions on symfony/symfony#45711

@kbond kbond force-pushed the invalidate-cache-command branch from 19d816a to 6ecb700 Compare March 15, 2022 13:14
@kbond
Copy link
Member Author

kbond commented Mar 15, 2022

I can't remember why I opened this PR when we also already have #16493... Probably a goof on my part.

Should I just modify this one to just change https://github.com/symfony/symfony-docs/pull/16493/files#diff-8d0ff073208b4ebfbd064d55c3957dda3d98d8e836adc48080072394208aabd4R709 to "Invalidate cache by tag(s)" (per @nicolas-grekas' suggestion in symfony/symfony#45711 (comment))?

@javiereguiluz
Copy link
Member

OK, closing this as a duplicate of #16493, which was already merged. Thanks!

@kbond kbond deleted the invalidate-cache-command branch March 21, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants