[Mailer] Add custom transport factories #16373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertMorenoDEV
commented
Jan 5, 2022
AlbertMorenoDEV
commented
Jan 5, 2022
AlbertMorenoDEV
commented
Jan 5, 2022
|
Hi, |
|
Hello, Does a transport gets created in every request? Just wondering because not sure how good would be doing that 🤔 Could you elaborate on a specific example? Cheers |
|
Albert, we finally merged your contribution. Sorry it took us so long. Also, congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be useful for very custom use cases where we need to extract some data or do something before being able to create the actual transport.
The feature apparently was added here: symfony/symfony#31946