Encore : firewall replace with allowedHosts #16522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56990f9 to
9dc01ff
Compare
|
Louis-Marie, thanks and congrats on your first Symfony Docs contribution 🎉 Please note that while merging, we restored some of the removed text (9a13511). It's not that your contribution was wrong, but we think that part of the original text is more explicit about the dangers and the reasons for using that option in this particular case. Thanks! |
|
Thanks @javiereguiluz 😄 No problem. Thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firewall option was removed since webpack-dev-server V4.0.0 and replace with allowedHosts.
https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md#bug-fixes-15