Add information to sub request #16561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iDara77
reviewed
Mar 7, 2022
94noni
reviewed
Nov 9, 2022
| @@ -742,6 +742,11 @@ look like this:: | |||
|
|
|||
| .. _http-kernel-resource-locator: | |||
|
|
|||
| Also, note that by default, if the ``_format`` attribute is not set in your request, the value will be ``html``. | |||
There was a problem hiding this comment.
is this the best part to add such info notice for such _format ?
OskarStark
reviewed
Aug 14, 2023
| @@ -742,6 +742,11 @@ look like this:: | |||
|
|
|||
| .. _http-kernel-resource-locator: | |||
There was a problem hiding this comment.
this must be moved above the next Headline Locating Resources again
There was a problem hiding this comment.
Done while merging. Thanks.
7e19f17 to
4421eaa
Compare
|
We finally merged this. Thanks a lot Damien ... and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some information about _format attribute default value because I spend some times to understand why this wasn't working for me. Now I know why it was not working, _format value was html by default and I get no error message. So I just share with orther developers this little update to avoid them spending the same time.
Thank you, have a nice day :)