Add NAME const for UID types
#16866
Merged
Add NAME const for UID types
#16866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NAME const for UID typesNAME const for UID types
AndreasA
reviewed
Jun 14, 2022
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 20, 2022
…lsiegert) This PR was merged into the 6.2 branch. Discussion ---------- [DoctrineBridge] Add `NAME` const for UID types | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#16866 This allows to refer to the constant instead of an "arbitrary" string. For example: ```php #[ORM\Column(type: UuidType::NAME)] private $foo; ``` Doctrine [already does it this way][1] in its documentation. The name of the constant is taken from the already existing `Symfony\Bridge\Doctrine\Tests\PropertyInfo\Fixtures\DoctrineFooType` class, where a constant with a similar purpose already exists (albeit this one is `private`). Another possibility would be `UlidType::ULID` and `UuidType::UUID` as shown in Doctrine's [Custom Mapping Types][2] documentation. [1]: https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/reference/basic-mapping.html [2]: https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/cookbook/custom-mapping-types.html Commits ------- 0273fde [DoctrineBridge] Add `NAME` const for UID types
symfony-splitter
pushed a commit
to symfony/doctrine-bridge
that referenced
this pull request
Jul 20, 2022
…lsiegert) This PR was merged into the 6.2 branch. Discussion ---------- [DoctrineBridge] Add `NAME` const for UID types | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#16866 This allows to refer to the constant instead of an "arbitrary" string. For example: ```php #[ORM\Column(type: UuidType::NAME)] private $foo; ``` Doctrine [already does it this way][1] in its documentation. The name of the constant is taken from the already existing `Symfony\Bridge\Doctrine\Tests\PropertyInfo\Fixtures\DoctrineFooType` class, where a constant with a similar purpose already exists (albeit this one is `private`). Another possibility would be `UlidType::ULID` and `UuidType::UUID` as shown in Doctrine's [Custom Mapping Types][2] documentation. [1]: https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/reference/basic-mapping.html [2]: https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/cookbook/custom-mapping-types.html Commits ------- 0273fde6a5 [DoctrineBridge] Add `NAME` const for UID types
Documentation update for symfony/symfony#46642.
|
Marcel, thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation update for symfony/symfony#46642.