[BrowserKit] Add response management to BrowserKit documentation (without toArray) #16949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Jul 8, 2022
components/browser_kit.rst
Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| When using the BrowserKit component, you may need to deal with responses of | ||
| the requests you made. To do so, you simply have to make a request, then call |
There was a problem hiding this comment.
Suggested change
| the requests you made. To do so, you simply have to make a request, then call | |
| the requests you made. To do so, you need to call |
There was a problem hiding this comment.
Thank you for the suggestion!
About version 4.4, the getResponse() method didn't exist at this time. That's why I targeted 5.4 🙂
There was a problem hiding this comment.
There was a problem hiding this comment.
Oooh that was moved to AbstractBrowser after, I did not check Client! Thank you, I'm rebasing!
c56eaca to
fc7ee50
Compare
1f5fb49 to
67b08ad
Compare
|
5.4 is still used in the description of this issue and the milestone. Update: this is a known issue of the Carson bot: symfony-tools/carsonbot#176 |
|
Not able to edit milestone and so on but updated the description, thank you! |
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16580 for 4.4 (without
toArray())