[Messenger] Add messenger rate_limiter docs #17203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8073793 to
234d296
Compare
fabpot
requested changes
Aug 19, 2022
94noni
reviewed
Aug 19, 2022
|
|
||
| .. caution:: | ||
|
|
||
| When a rate limiter is configured on a transport, it will block the whole |
There was a problem hiding this comment.
What about such wordings?
As a rate limiter on a transport will block its worker from consuming when the limit is hit,
you may run a dedicated worker handling such transport to avoid others being blocked.
(Perhaps the english is not perfect) but commenting for the idea
There was a problem hiding this comment.
I think both are good, it is just a personal preference thing. I don't mind changing it, I also don't mind keeping it as is.
maxhelias
approved these changes
Nov 23, 2023
|
Let's merge it after over a year. |
|
Just came through this, very helpful. |
|
It took time, but here we go, this is in now. Thank you very much @bobvandevijver. |
|
Than you @OskarStark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for symfony/symfony#41171