[Validator] Add pattern in Regex constraint violations
#17436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Nov 17, 2022
Perhaps create a new carsonbot action that detect the symfony/symfony PR number, and check its state if merged or not ^^ |
94noni
approved these changes
Nov 18, 2022
|
We created the |
pattern in Regex constraint violations
4ae4534 to
db15323
Compare
|
@OskarStark I rebased on 6.3 |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Dec 9, 2022
…olations (alamirault)
This PR was merged into the 6.3 branch.
Discussion
----------
[Validator] Add `{{pattern}}` to `Regex` constraint violations
| Q | A
| ------------- | ---
| Branch? | 6.3
| Bug fix? | no
| New feature? | yes
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs/pull/17436
This PR add parameter `pattern` to `Regex` constraints violations.
This is useful for building message to technical users/consumers. (like limit, choices, min, max ... in other constraints )
Commits
-------
369b051 [Validator] Add pattern in Regex constraint violations
|
It took time, but here we go, this is in now. Thank you very much Antoine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 6.3
symfony/symfony#48232
Waiting Code merge (Is there a tip in order to set label at PR creation ?)