Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update routing.rst #17565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update routing.rst #17565

wants to merge 2 commits into from

Conversation

micter59
Copy link
Contributor

Add a note about allowing the http_method_override in the framework.yml file
symfony/symfony#48658

Add a note about allowing the http_method_override in the framework.yml file
symfony/symfony#48658
@MatTheCat
Copy link
Contributor

Given the option was disabled in the 5.3 recipe (cf. symfony/recipes#892) I think this PR should target the 5.4 branch.

Also it concerns form usage so maybe it would be better to add something like

framework.http_method_override needs to be set for this to work.

at the bottom of the existing tip.

@micter59 micter59 changed the base branch from 6.2 to 5.4 December 15, 2022 11:13
@micter59 micter59 requested a review from xabbuh as a code owner December 15, 2022 11:13
@micter59 micter59 changed the base branch from 5.4 to 6.2 December 15, 2022 11:14
@micter59
Copy link
Contributor Author

Sorry, i don't know how to make the modification now. If I change from symfony:6.2 to 5.4, this makes a lot of modification that I don't want.

@MatTheCat
Copy link
Contributor

I think the simplest way would be to reset your branch on 5.4, then you can (re)add your changes, force-push and change the PR’s target.

@micter59 micter59 closed this Dec 15, 2022
@micter59
Copy link
Contributor Author

I'm a bit lost with Git & Github. Sorry for the mess I do. I just wanted to help.
I've open a new PR targeting the 5.4.
I hope it will be ok this time.

@micter59 micter59 deleted the patch-1 branch December 15, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants