Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Remove not implemented behavior #17576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

[DependencyInjection] Remove not implemented behavior #17576

merged 1 commit into from
Feb 21, 2023

Conversation

upyx
Copy link
Contributor

@upyx upyx commented Dec 16, 2022

Currently numeric keys are used, but it will be deprecated and changed in 7.0.

Deprecation: symfony/symfony#48686
New behavior: symfony/symfony#48653

@carsonbot carsonbot added this to the 5.4 milestone Dec 16, 2022
@upyx upyx mentioned this pull request Dec 16, 2022
Merged
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Dec 20, 2022
@carsonbot carsonbot modified the milestones: 5.4, next Dec 20, 2022
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Dec 22, 2022
@nicolas-grekas
feature #48686 [DependencyInjection] Deprecate integer keys in "servi…
ff6913e 
…ce_locator" config (upyx)

This PR was merged into the 6.3 branch.

Discussion
----------

[DependencyInjection] Deprecate integer keys in "service_locator" config

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | Deprecation befor #48653
| License       | MIT
| Doc PR        | symfony/symfony-docs#17576

It deprecates undefined/wrong behaviour of https://symfony.com/doc/current/service_container/service_subscribers_locators.html#defining-a-service-locator

Commits
-------

57c2365 [DependencyInjection] Deprecate integers keys in "service_locator" config
@upyx
Copy link
Contributor Author

upyx commented Jan 4, 2023

@OskarStark
Described behavior ("if the element has no key, the ID of the original service is used") hasn't been implemented. There is a bug in the documentation. Hovewer, I'm going to implement it in 7.0.

The PR removes a wrong description from older versions.

@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Jan 10, 2023
@OskarStark OskarStark requested a review from wouterj January 10, 2023 08:54
@OskarStark OskarStark mentioned this pull request Jan 10, 2023
Merged
OskarStark added a commit that referenced this pull request Jan 10, 2023
@OskarStark
minor #17705 Fix: Typos (OskarStark)
0476f31 
This PR was merged into the 5.4 branch.

Discussion
----------

Fix: Typos

Spotted in
* #17576

Commits
-------

b93967a Fix: Typos
@xabbuh xabbuh modified the milestones: next, 5.4 Feb 3, 2023
upyx
upyx commented Feb 20, 2023
View reviewed changes
Copy link
Contributor Author

@upyx upyx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo has been fixed.

@OskarStark
Copy link
Contributor

After we merge this in 5.4 can you submit a PR with the new behavior for 6.3?

@upyx
Copy link
Contributor Author

upyx commented Feb 21, 2023

After we merge this in 5.4 can you submit a PR with the new behavior for 6.3?

It's have already been merged in symfony/symfony#48686. And it will be changed again in 7.0.

@OskarStark
Copy link
Contributor

Sorry I meant, create a PR against the Symfony docs repo

@upyx
Copy link
Contributor Author

upyx commented Feb 21, 2023

Sorry I meant, create a PR against the Symfony docs repo

Yes, I will check the 6.3 branch and create a PR with necessary changes (if any).

@carsonbot carsonbot changed the title Remove not implemented behavior [DependencyInjection] Remove not implemented behavior Feb 21, 2023
@javiereguiluz
Copy link
Member

Thanks Sergey ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 1a37dd9 into symfony:5.4 Feb 21, 2023
alexandre-daubois added a commit to alexandre-daubois/symfony-docs that referenced this pull request Jun 21, 2023
@alexandre-daubois
[DependencyInjection] Remove not implemented behavior
b6a23b7 
Follow-up symfony#17576
@alexandre-daubois alexandre-daubois mentioned this pull request Jun 21, 2023
Merged
javiereguiluz added a commit that referenced this pull request Jun 21, 2023
@javiereguiluz
minor #18441 [DependencyInjection] Remove not implemented behavior (a…
aba4834 
…lexandre-daubois)

This PR was merged into the 6.2 branch.

Discussion
----------

[DependencyInjection] Remove not implemented behavior

Follow-up #17576

Commits
-------

b6a23b7 [DependencyInjection] Remove not implemented behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@wouterj wouterj Awaiting requested review from wouterj

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@upyx @OskarStark @javiereguiluz @xabbuh @carsonbot