-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Notifier] do not display todo doc on site #17627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifier] do not display todo doc on site #17627
Conversation
This should be parsed differently by the docs-builder @weaverryan |
Do you think it's a parsing issue ? Syntax seems to be incomplete regarding others todo block |
Yes, because before, when we use cc @nikophil |
Hello, the problem comes from the rst parser. rst language reference says comments could look like this, which works with the parser: .. This is a comment or this, which is not considered as a comment and is a bug in the parser ..
this is a comment they don't give an example for this kind of block (not even in sphinx doc) .. first comment
still a comment in the same block but they do provide a "syntax diagram" which makes me think this should also be considered as a comment:
Still, if Sphynx did consider the later as a block comment, maybe this behavior could land in the parser as well. .. I am a comment and appear in grey
I am also in grey, so I am a comment
I am not in grey, because I am not a comment I've open a PR the rst repository |
PR is merged, let's wait for them to release the patch 😊 |
@OskarStark @weaverryan The PR has been released in 0.5.3 |
Thanks Matthieu. |
@nikophil thanks! I've tagged a new version of symfony/docs-builder too, so we'll get your latest fixes. |
I've noticed on bottom of Notifier page a todo block displayed on site, just a small change to hide it