Adapt CsvEncoder no_headers context
#17907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamirault thanks for this contribution 🙏 The proposed change is small so I guess it's OK, but please don't send large contributions to Serializer docs until we finish its revamp. See #17814. Thanks! |
645c4d7 to
d3e39ee
Compare
|
@javiereguiluz I rebased, and as it's not a major structure change, we can review/merge it 😄 Thanks ! |
OskarStark
approved these changes
Sep 23, 2023
d3e39ee to
05f0a33
Compare
|
Thank you @alamirault. |
xabbuh
added a commit
that referenced
this pull request
Jan 7, 2024
This PR was merged into the 5.4 branch. Discussion ---------- Adapt CsvEncoder `no_headers` context Try fix #15243 Default behavior: https://github.com/symfony/symfony/blob/c7a7cb8841bb54a68c967b3ea0e57024802b96ed/src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php#L45-L60 With `no_headers` https://github.com/symfony/symfony/blob/c7a7cb8841bb54a68c967b3ea0e57024802b96ed/src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php#L647-L653 Commits ------- 2bfe5da Adapt CsvEncode no_headers context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try fix #15243
Default behavior:
https://github.com/symfony/symfony/blob/c7a7cb8841bb54a68c967b3ea0e57024802b96ed/src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php#L45-L60
With
no_headershttps://github.com/symfony/symfony/blob/c7a7cb8841bb54a68c967b3ea0e57024802b96ed/src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php#L647-L653