[HttpClient] Replace interface HttpClient by HttpAsyncClient #18064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eda7344 to
2551bf7
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Mar 16, 2023
…cate httplugs use like psr18 client (simonberger) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | Fix #49644 | License | MIT | Doc PR | symfony/symfony-docs#18064 This MR does 2 closely related things to try to fully integrate the HttplugClient with the unique features it brings and on the other hand deprecate its use like a psr18 client which it is in a pending deprecation state since a long time. - Added a new services `httplug.http_client` and alias `Http\Client\HttpAsyncClient` to inject the the `HttplugClient`. - Make the available service `Http\Client\HttpClient` a deprecated alias of it - Create httplug.<scoped_client_id> services for all scoped clients like it is done with the psr18 ClientInterface Commits ------- 20ab567 [FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Mar 16, 2023
…cate httplugs use like psr18 client (simonberger) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | Fix #49644 | License | MIT | Doc PR | symfony/symfony-docs#18064 This MR does 2 closely related things to try to fully integrate the HttplugClient with the unique features it brings and on the other hand deprecate its use like a psr18 client which it is in a pending deprecation state since a long time. - Added a new services `httplug.http_client` and alias `Http\Client\HttpAsyncClient` to inject the the `HttplugClient`. - Make the available service `Http\Client\HttpClient` a deprecated alias of it - Create httplug.<scoped_client_id> services for all scoped clients like it is done with the psr18 ClientInterface Commits ------- 20ab567385 [FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client
|
I think we can skip doing these changes, the example are still valid in the context that is described (a third party lib that consumes httplug) |
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 28, 2023
…cate httplugs use like psr18 client (simonberger) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | Fix #49644 | License | MIT | Doc PR | symfony/symfony-docs#18064 This MR does 2 closely related things to try to fully integrate the HttplugClient with the unique features it brings and on the other hand deprecate its use like a psr18 client which it is in a pending deprecation state since a long time. - Added a new services `httplug.http_client` and alias `Http\Client\HttpAsyncClient` to inject the the `HttplugClient`. - Make the available service `Http\Client\HttpClient` a deprecated alias of it - Create httplug.<scoped_client_id> services for all scoped clients like it is done with the psr18 ClientInterface Commits ------- 20ab567385 [FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small adjustment of the Httplug blockof the HttpClient documentation, following the changes of symfony/symfony#49691