[Doctrine] Deprecate Doctrine lifecycle subscribers #18457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would not put that as the first content in the section, especially given that the code snippet below already uses the attribute. |
mdeboer
suggested changes
Jul 4, 2023
There was a problem hiding this comment.
Judging by symfony/symfony#49918, I would say that using lifecycle subscribers as services is deprecated from 6.3 and that it's advised to register lifecycle listeners instead.
The exact deprecation message reads:
Using Doctrine subscribers as services is deprecated, declare listeners instead
Edit: Nevermind, I see that's already in the second paragraph 😅
|
OK, I've removed the first deprecation notice and left the second one. Thanks for the reviews. |
ostrolucky
approved these changes
Jul 4, 2023
2e2688a to
77769de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#49918 and doctrine/DoctrineBundle#1664