Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove deprecated directive #18479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

Remove deprecated directive #18479

merged 1 commit into from
Jul 3, 2023

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark requested a review from javiereguiluz June 30, 2023 17:48
@OskarStark OskarStark requested a review from xabbuh as a code owner June 30, 2023 17:48
@carsonbot carsonbot added this to the 7.0 milestone Jun 30, 2023
javiereguiluz
javiereguiluz approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if it'd be better to reword this instead of removing it. But, since he behavior is very obvious (you are defining the timezone of your model data here ... so your model data must have this timezone; it's so obvious). So, let's remove it. Thanks!

@OskarStark OskarStark merged commit a66cc19 into symfony:7.0 Jul 3, 2023
@OskarStark OskarStark deleted the feature/remove-deprecation branch July 3, 2023 14:24
@javiereguiluz javiereguiluz mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @javiereguiluz @carsonbot