Clarify routing documentation on trailing optional parameters #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Routes with optional parameters at the end will not match on requests | ||
| with a trailing slash (i.e. /blog/). In this case the slash is a separator and | ||
| should not be used if the optional parameter isn't passed. |
There was a problem hiding this comment.
Each line should be indented by 4 spaces
| .. tip:: | ||
|
|
||
| Routes with optional parameters at the end will not match on requests | ||
| with a trailing slash (i.e. /blog/). In this case the slash is a separator and |
There was a problem hiding this comment.
You should use a double backtick around /blog/:
with a trailing slash (i.e. ``/blog/``). In this case the slash is a seperator and
weaverryan
added a commit
that referenced
this pull request
Nov 17, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in issue symfony/symfony#5869 the Routing documentation is a little unclear as to when routes with optional parameters at the end are matched.
The above route will only match on /hello and /hello/name, it will not match /hello/. I would like to clarify this in the documentation to avoid any confusion in the future.